From e87cd570d2dc38d38205330e12beda4f510f854b Mon Sep 17 00:00:00 2001
From: Stephan <stephane.gay@hazelcast.com>
Date: Sun, 12 Dec 2021 19:42:25 +0100
Subject: [PATCH] .12

---
 .github/workflows/hz.js               | 40 ++++++++++++++++++
 .github/workflows/publish-release.yml | 60 ++++++++++++---------------
 2 files changed, 66 insertions(+), 34 deletions(-)
 create mode 100644 .github/workflows/hz.js

diff --git a/.github/workflows/hz.js b/.github/workflows/hz.js
new file mode 100644
index 0000000..a599ceb
--- /dev/null
+++ b/.github/workflows/hz.js
@@ -0,0 +1,40 @@
+
+// see https://github.com/actions/github-script
+// , core, glob, io, exec, require
+module.exports = function (github, context) {
+    
+    var module = {}
+    
+    // this is *not* exported
+    function noop ( ) { }
+
+    // this *is* exported
+    module.getReleaseByTag = function (tag_name) {
+        var rel = null
+        try {
+            // this does *not* return draft releases, so we have to list them
+            //rel = await github.repos.getReleaseByTag({ ... })
+            const rels = await github.repos.listReleases({
+                owner: context.repo.owner,
+                repo: context.repo.repo
+            })
+            for (const r of rels.data) {
+                if (r.tag_name === tag_name) {
+                    rel = r
+                    break
+                }
+            }
+        }
+        catch (error) {
+            return null
+        }
+        return rel
+    }
+    
+    module.getRefReleaseTag = function (ref) {
+        // test, must start with 'refs/heads/release/' 19 chars
+        return "v" + ref.substring(19)
+    }
+    
+    return module;
+}
diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml
index be8f2e7..c98408c 100644
--- a/.github/workflows/publish-release.yml
+++ b/.github/workflows/publish-release.yml
@@ -1,11 +1,23 @@
 name: Publish Release
 on: workflow_dispatch
+  input:
+    confirm:
+      description: 'This is really going to release. Are you sure?'
+      required: true
+      default: false
 jobs:
   job:
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/heads/release/')
     steps:
     
+    - name: Confirm
+      if: ${{ github.event.inputs.confirm }} == false
+      uses: actions/github-script@v4
+      with:
+        script: |
+          core.setFailed(`Not confirmed (confirm = '${{ github.event.inputs.confirm }}').`)
+    
     - name: Validate the release
       uses: actions/github-script@v4
       with:
@@ -13,27 +25,14 @@ jobs:
         # token needed to see draft releases when getting all releases
         github-token: ${{ secrets.MY_GITHUB_TOKEN_TESTREPO }}
         script: |
-          const ver = "${{ github.ref }}".substring(19)
-          const tag = "v" + ver
-          var rel = null
-          try {
-            // this does *not* return draft releases, so we have to list them
-            //rel = await github.repos.getReleaseByTag({ ... })
-            const rels = await github.repos.listReleases({
-              owner: context.repo.owner,
-              repo: context.repo.repo
-            })
-            for (const r of rels.data) {
-              if (r.tag_name === tag) {
-                  rel = r
-                  break
-              }
-            }
-          }
-          catch (error) {
-            core.setFailed(`Could not find a release for tag ${tag}.`)
+          const hz = require("hz.js")(github, context)
+          const ref = "${{ github.ref }}"
+          const tag = hz.getRefReleaseTag(ref)
+          if (tag === null) {
+            core.setFailed(`Invalid reference ${ref} is not release/<version>.`)
             return
           }
+          var rel = hz.getReleaseByTag(tag)
           if (rel === null) {
             core.setFailed(`Could not find a release for tag ${tag}.`)
             return
@@ -81,21 +80,14 @@ jobs:
       uses: actions/github-script@v4
       with:
         script: |
-          const ver = "${{ github.ref }}".substring(19)
-          const tag = "v" + ver
-          var rel = null
-          // no, see above
-          //const rel = await github.repos.getReleaseByTag({ ... })
-          const rels = await github.repos.listReleases({
-              owner: context.repo.owner,
-              repo: context.repo.repo
-            })
-            for (const r of rels.data) {
-              if (r.tag_name === tag) {
-                  rel = r
-                  break
-              }
-            }
+          const hz = require("hz.js")(github, context)
+          const ref = "${{ github.ref }}"
+          const tag = hz.getRefReleaseTag(ref)
+          if (tag === null) {
+            core.setFailed(`Invalid reference ${ref} is not release/<version>.`)
+            return
+          }
+          var rel = hz.getReleaseByTag(tag)
           await github.repos.updateRelease({
             owner: context.repo.owner,
             repo: context.repo.repo,