Foo

.github/workflows/hz.js

@@ -1,40 +0,0 @@
-
-// see https://github.com/actions/github-script
-// , core, glob, io, exec, require
-module.exports = function (github, context) {
-    
-    var module = {}
-    
-    // this is *not* exported
-    function noop ( ) { }
-
-    // this *is* exported
-    module.getReleaseByTag = async function (tag_name) {
-        var rel = null
-        try {
-            // this does *not* return draft releases, so we have to list them
-            //rel = await github.repos.getReleaseByTag({ ... })
-            const rels = await github.repos.listReleases({
-                owner: context.repo.owner,
-                repo: context.repo.repo
-            })
-            for (const r of rels.data) {
-                if (r.tag_name === tag_name) {
-                    rel = r
-                    break
-                }
-            }
-        }
-        catch (error) {
-            return null
-        }
-        return rel
-    }
-    
-    module.getRefReleaseTag = function (ref) {
-        // test, must start with 'refs/heads/release/' 19 chars
-        return "v" + ref.substring(19)
-    }
-    
-    return module;
-}

.github/workflows/publish-release.yml

@@ -1,33 +1,11 @@
-name: Publish 
-
-#meh
-on: 
-  workflow_dispatch:
-    inputs:
-      confirm:
-        description: "This is really going to release. Enter \'yolo\' to confirm that you really want to do it."
-        required: true
-        default: ""
-        
+name: Publish Release
+on: workflow_dispatch
 jobs:
   job:
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/heads/release/')
     steps:
     
-    - name: Confirm
-      uses: actions/github-script@v4
-      with:
-        script: |
-          if ("${{ github.event.inputs.confirm }}" != "yolo") {
-            core.setFailed(`Not confirmed (confirm = '${{ github.event.inputs.confirm }}').`)
-          }
-    
-    - name: Checkout
-      uses: actions/checkout@v2
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        
     - name: Validate the release
       uses: actions/github-script@v4
       with:
@@ -35,14 +13,27 @@ jobs:
         # token needed to see draft releases when getting all releases
         github-token: ${{ secrets.MY_GITHUB_TOKEN_TESTREPO }}
         script: |
-          const hz = require("./.github/workflows/hz.js")(github, context)
-          const ref = "${{ github.ref }}"
-          const tag = hz.getRefReleaseTag(ref)
-          if (tag === null) {
-            core.setFailed(`Invalid reference ${ref} is not release/<version>.`)
+          const ver = "${{ github.ref }}".substring(19)
+          const tag = "v" + ver
+          var rel = null
+          try {
+            // this does *not* return draft releases, so we have to list them
+            //rel = await github.repos.getReleaseByTag({ ... })
+            const rels = await github.repos.listReleases({
+              owner: context.repo.owner,
+              repo: context.repo.repo
+            })
+            for (const r of rels.data) {
+              if (r.tag_name === tag) {
+                  rel = r
+                  break
+              }
+            }
+          }
+          catch (error) {
+            core.setFailed(`Could not find a release for tag ${tag}.`)
             return
           }
-          var rel = await hz.getReleaseByTag(tag)
           if (rel === null) {
             core.setFailed(`Could not find a release for tag ${tag}.`)
             return
@@ -65,6 +56,11 @@ jobs:
           }
           // everything is OK
           
+    - name: Checkout
+      uses: actions/checkout@v2
+      with:
+        token: ${{ secrets.GITHUB_TOKEN }}
+        
     - name: Configure repository
       shell: bash
       run: |
@@ -85,14 +81,21 @@ jobs:
       uses: actions/github-script@v4
       with:
         script: |
-          const hz = require("./.github/workflows/hz.js")(github, context)
-          const ref = "${{ github.ref }}"
-          const tag = hz.getRefReleaseTag(ref)
-          if (tag === null) {
-            core.setFailed(`Invalid reference ${ref} is not release/<version>.`)
-            return
-          }
-          var rel = await hz.getReleaseByTag(tag)
+          const ver = "${{ github.ref }}".substring(19)
+          const tag = "v" + ver
+          var rel = null
+          // no, see above
+          //const rel = await github.repos.getReleaseByTag({ ... })
+          const rels = await github.repos.listReleases({
+              owner: context.repo.owner,
+              repo: context.repo.repo
+            })
+            for (const r of rels.data) {
+              if (r.tag_name === tag) {
+                  rel = r
+                  break
+              }
+            }
           await github.repos.updateRelease({
             owner: context.repo.owner,
             repo: context.repo.repo,